Skip to content

feat(api): add screencast size option - #3085

Closed
Rohan Patnaik (rohan-patnaik) wants to merge 1 commit into
microsoft:mainfrom
rohan-patnaik:feat-screencast-size
Closed

feat(api): add screencast size option#3085
Rohan Patnaik (rohan-patnaik) wants to merge 1 commit into
microsoft:mainfrom
rohan-patnaik:feat-screencast-size

Conversation

@rohan-patnaik

@rohan-patnaik Rohan Patnaik (rohan-patnaik) commented May 22, 2026

Copy link
Copy Markdown
Contributor

Fixes #3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

  • python3 - <<'PY' signature import check for async and sync Screencast.start
  • git diff --check

@Skn0tt

Simon Knott (Skn0tt) commented Jun 8, 2026

Copy link
Copy Markdown
Member

Don't change the _generated.py files by hand.

@rohan-patnaik

Rohan Patnaik (rohan-patnaik) commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

@rohan-patnaik

Rohan Patnaik (rohan-patnaik) commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Add size option to page.screencast.start()

2 participants

@rohan-patnaik @Skn0tt